Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🐛 Bug]: Too tight dependency on typing-extensions #14278

Closed
nijel opened this issue Jul 19, 2024 · 5 comments · Fixed by #14297
Closed

[🐛 Bug]: Too tight dependency on typing-extensions #14278

nijel opened this issue Jul 19, 2024 · 5 comments · Fixed by #14297

Comments

@nijel
Copy link
Contributor

nijel commented Jul 19, 2024

What happened?

Upgrade from selenium 4.22.0 to 4.23.0 is impossible because of tightened dependencies on typing-extensions as observed in WeblateOrg/weblate#12090:

Because django-stubs==5.0.2 depends on typing-extensions>=4.11.0 and
selenium==4.23.0 depends on typing-extensions>=4.9.0,<4.10.dev0, we can
conclude that django-stubs==5.0.2 and selenium==4.23.0 are incompatible.

It seems to be used only for:

from typing_extensions import deprecated

This is very unlikely to break between versions, so could the dependency be relaxed a bit? I think typing-extensions>=4.9.0,<5 would work well in this case (this is basically the same as typing-extensions=~4.9 used in 4.22.0).

This was changed by f69260d in #14187.

How can we reproduce the issue?

pip install django-stubs==5.0.2 selenium==4.23.0

Relevant log output

The conflict is caused by:
    django-stubs 5.0.2 depends on typing-extensions>=4.11.0
    selenium 4.23.0 depends on typing_extensions~=4.9.0

Operating System

Linux

Selenium version

4.23.0

What are the browser(s) and version(s) where you see this issue?

N/A

What are the browser driver(s) and version(s) where you see this issue?

N/A

Are you using Selenium Grid?

No response

Copy link

@nijel, thank you for creating this issue. We will troubleshoot it as soon as we can.


Info for maintainers

Triage this issue by using labels.

If information is missing, add a helpful comment and then I-issue-template label.

If the issue is a question, add the I-question label.

If the issue is valid but there is no time to troubleshoot it, consider adding the help wanted label.

If the issue requires changes or fixes from an external project (e.g., ChromeDriver, GeckoDriver, MSEdgeDriver, W3C), add the applicable G-* label, and it will provide the correct link and auto-close the issue.

After troubleshooting the issue, please add the R-awaiting answer label.

Thank you!

@nijel
Copy link
Contributor Author

nijel commented Jul 19, 2024

I've made #14279 with a proposed fix.

@nijel nijel changed the title [🐛 Bug]: Too tight dependency on typing_extensions [🐛 Bug]: Too tight dependency on typing-extensions Jul 19, 2024
@devkral
Copy link

devkral commented Jul 22, 2024

Additional note for the maintainers as they are likely more familiar with JS:

In python version resolving works quite different. It is not possible to have multiple versions of a package, so relaxed dependencies are normally used.

If you want to hard limit dependencies for tests it is maybe better to use hatch, poetry or pdm for having a test environment.
Except hatch all suggestions support lockfiles.

@mdmintz
Copy link
Contributor

mdmintz commented Jul 23, 2024

I created #14297, to handle all dependencies that needed to be updated.

Copy link

This issue has been automatically locked since there has not been any recent activity since it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Aug 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants