From 462194534a884be5bbd47d27ce2a88d4ffa286b6 Mon Sep 17 00:00:00 2001 From: titusfortner Date: Sat, 23 Sep 2023 11:17:58 -0500 Subject: [PATCH] [rb] remove assertions in virtual authenticator tests Chrome 117 started returning the same values for rpId and userHandle in both resident and non-resident credentials. This behavior is not evaluated in wpt tests, so removing the checks in Selenium. --- .../selenium/webdriver/virtual_authenticator_spec.rb | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/rb/spec/integration/selenium/webdriver/virtual_authenticator_spec.rb b/rb/spec/integration/selenium/webdriver/virtual_authenticator_spec.rb index 35402fe9c7afe..594c407a27e77 100644 --- a/rb/spec/integration/selenium/webdriver/virtual_authenticator_spec.rb +++ b/rb/spec/integration/selenium/webdriver/virtual_authenticator_spec.rb @@ -194,17 +194,10 @@ def credential(id) expect(credentials.length).to eq(2) res_cred_output = credentials.find { |cred| Credential.encode(cred.id).match res_cred_resp['id'] } - non_res_cred_output = credentials.tap { |cred| cred.delete(res_cred_output) }.first + non_res_cred_output = credentials.find { |cred| cred != res_cred_output } expect(res_cred_output.resident_credential?).to be true - expect(res_cred_output.rp_id).to eq 'localhost' - expect(res_cred_output.sign_count).to eq 1 - expect(res_cred_output.user_handle).to eq [1] - expect(non_res_cred_output.resident_credential?).to be false - expect(non_res_cred_output.rp_id).to be_nil - expect(non_res_cred_output.sign_count).to eq 1 - expect(non_res_cred_output.user_handle).to be_nil end end