Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Cleanup Command deletes all Floorp data #12958

Open
3 tasks done
WNnitro opened this issue Mar 16, 2024 · 2 comments · May be fixed by #14417
Open
3 tasks done

[Bug]: Cleanup Command deletes all Floorp data #12958

WNnitro opened this issue Mar 16, 2024 · 2 comments · May be fixed by #14417
Labels
bug

Comments

@WNnitro
Copy link

WNnitro commented Mar 16, 2024

Prerequisites

  • I have written a descriptive issue title.
  • I have searched all issues/PRs to ensure it has not already been reported or fixed.
  • I have verified that I am using the latest version of Scoop and corresponding bucket.

Package Name

Floorp

Expected/Current Behaviour

I'm trying to run scoop cleanup * to delete previous installations of my packages. However, this command deletes the Profiles folder of my Floorp installation instead, which is not what im expecting.
img-2024-03-15-18-19-05

Steps to Reproduce

1. Install Scoop
2. run 'scoop bucket add extras'
3. run 'scoop install extras/floorp'
4. open Floorp, close it.
5. run 'scoop cleanup *'

Possible Solution

not deleting the profiles folder.

Scoop and Buckets Version

PS C:\Users\Administrator> scoop --version
Current Scoop version:
v0.3.1 - Released at 2022-11-15

'extras' bucket:
2a36a45d4 (HEAD -> master, origin/master, origin/HEAD) tidal: Add version 2.36.2 (#12941)

'LuoHuiRu_ScoopBucket' bucket:
3fdae5c (HEAD -> master, origin/master, origin/HEAD) VSCode-Nightly: Update to version 1.88.0-insider_1710392702683

'main' bucket:
471486b0d (HEAD -> master, origin/master, origin/HEAD) oh-my-posh: Update to version 19.17.2

'nerd-fonts' bucket:
db6ccd1 (HEAD -> master, origin/master, origin/HEAD) [email protected]: Fix hash (Closes #280)

'nonportable' bucket:
25964b17 (HEAD -> master, origin/master, origin/HEAD) office-365-apps-minimal-np: Update to version 0.7.7.0

'okibcn_ScoopMaster' bucket:
f86fdde1b3 (HEAD -> master, origin/master, origin/HEAD) Update timestamp 2024-03-15T10:52:54Z

'versions' bucket:
749fc6345 (HEAD -> master, origin/master, origin/HEAD) zig-dev: Update to version 0.12.0-dev.3303

Scoop Config

scoop config

last_update                       alias                      scoop_branch scoop_repo
-----------                       -----                      ------------ ----------
2024-03-15T21:48:45.4486962+07:00 @{outdated=scoop-outdated} master       https://github.com/ScoopInstaller/Scoop

PowerShell Version

PS C:\Users\Administrator> $PSVersionTable

Name                           Value
----                           -----
PSVersion                      5.1.22621.2506
PSEdition                      Desktop
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.22621.2506
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           1.1.0.1

Additional Softwares

Floorp
@WNnitro WNnitro added the bug label Mar 16, 2024
@SegoCode
Copy link
Contributor

SegoCode commented Jun 26, 2024 •
edited
Loading

Hello,

That happens because the manifest has been reused from Firefox and all its forks, but the portable version in this case

Extras/bucket/floorp.json

Line 14 in 8f7ba90

"url": "https://github.com/Floorp-Projects/Floorp-Portable/releases/download/11.14.0-portable/floorp-11.14.0-portable-windows-x86_64.zip",

Unlike other Firefox forks, this portable version of Floorp creates a whole directory tree simulating the appdata. Therefore, the persist folder doesn't match with the application data.

Scoop app
imagen

Scoop persist
imagen

I dont recommend make a script in the manifest to create and persist this entire directory tree. Instead, download the installer version from https://github.com/Floorp-Projects/Floorp/releases/download/v11.14.1/floorp-win64.installer.exe, extract it like a zip and get the 'core' folder. This way, easier to maintain, the script for this 'Firefox' will be the same as for the other 'Firefox' versions, with that, this actual note make sense:

Notes
-----
To set profile 'Scoop' as *DEFAULT*, or profiles/settings was lost after update:
- Run 'Floorp Profile Manager', choose 'Scoop' then click 'Start Floorp'.
- Visit 'about:profiles' page in Floorp to check *DEFAULT* profile.
For details:
https://support.mozilla.org/en-US/kb/profile-manager-create-remove-switch-firefox-profiles

Currently even the "scoop" profile was not created.

@SegoCode SegoCode mentioned this issue Jun 26, 2024
Closed
1 task
@kyan001
Copy link

kyan001 commented Sep 10, 2024 •
edited
Loading

The Scoop version of Floorp saves the persistent profile path in Scoop/apps/floorp/Profiles/AppData/Floorp/profiles.ini.

However, Scoop sees the Scoop/apps/floorp/Profiles/ directory as an old version of Floorp, which will be removed when executing the scoop cleanup * command and prints Removing floorp: Profiles on the screen. Finally, on the next Floorp startup, a new Scoop/apps/floorp/Profiles/ is created, and the profile data is reset.

Solution:

  1. Remove Scoop\apps\floorp\current\portable.ini
  2. Copy Scoop\apps\floorp\Profiles\AppData\Floorp\profiles.ini to %APPDATA%\Floorp\profiles.ini and overwrite.
    • %APPDATA% = C:\Users\<username>\AppData\Roaming

@y2crow y2crow linked a pull request Nov 16, 2024 that will close this issue
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
3 participants
@kyan001 @SegoCode @WNnitro