Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NBodySimulator Benchmarks #271

Open
ChrisRackauckas opened this issue May 15, 2021 · 6 comments
Open

Fix NBodySimulator Benchmarks #271

ChrisRackauckas opened this issue May 15, 2021 · 6 comments

Comments

@ChrisRackauckas
Copy link
Member

Continuouing #245 here.

@SebastianM-C these time out. How long do they take?
@SebastianM-C
Copy link
Contributor

It is possible to be over an hour, but I'm not sure, I'll have to run them and see. Should I try to make it shorter? What should be the benchmark duration?

@ChrisRackauckas
Copy link
Member Author

They are failing at 6 hours.

@SebastianM-C
Copy link
Contributor

Oh... That's unexpected.

@SebastianM-C
Copy link
Contributor

Are there any logs available to see where it hangs / what happens?

@ChrisRackauckas
Copy link
Member Author

https://buildkite.com/julialang/scimlbenchmarks-dot-jl/builds/242#df9f5bc4-7f12-416e-8583-7e8e6088387b

@SebastianM-C
Copy link
Contributor

I ran them locally and it looks like it's not getting stuck, but that the benchmarks take very long
image

I'll try to have a look at some concrete examples to see if there are any performance regressions, but it may also be due to how many runs we have at different tolerances.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ChrisRackauckas @SebastianM-C