Skip to content
This repository has been archived by the owner on Sep 9, 2024. It is now read-only.

Tests failing on nightly #29

Closed
ivarne opened this issue Mar 11, 2014 · 3 comments
Closed

Tests failing on nightly #29

ivarne opened this issue Mar 11, 2014 · 3 comments
Labels

Comments

@ivarne
Copy link
Contributor

ivarne commented Mar 11, 2014

After JuliaLang/julia#5810 (comment), we get deprecation warnings, and failing tests due to a missing broacasting operator .\(Array{Float64,2}, Int64) in ODE.jl#L354. I do not feel confident enough to say what is really happening here.

@acroy
Copy link
Contributor

acroy commented Mar 11, 2014

The problem is that in the first tests jac (Jacobian) is a matrix with one element while F is just a scalar. In the old days this used to work ... In JuliaLang/julia#14 I handle the scalar case separately and this error doesn't occur. There are, however, also depreciation warnings, which are kind of strange. Could someone please try this

julia> midxdot = Array(typeof([1., 2.]), 4);

julia> fill!(midxdot, [1.,2.]);

julia> [1. 2. 2. 1.]*midxdot
WARNING: x::Number + A::Array is deprecated, use x .+ A instead.
 in + at deprecated.jl:26
 in generic_matvecmul at linalg/matmul.jl:310
 in generic_matvecmul at linalg/matmul.jl:274
 in * at linalg/matmul.jl:267
1-element Array{Any,1}:
 [6.0,12.0]

which seems to be wrong? (Edit: The result is correct of course, but the warning is strange?)

@acroy
Copy link
Contributor

acroy commented Mar 12, 2014

I could probably fix the issue with \, but I think we should move on and merge JuliaLang/julia#14 and then address JuliaLang/LinearAlgebra.jl#94 separately.

@acroy
Copy link
Contributor

acroy commented May 6, 2014

Should be solved by JuliaLang/julia#16 which avoids generic_matvecmul and thus JuliaLang/LinearAlgebra.jl#94.

@acroy acroy closed this as completed May 6, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants