web-manifest: describe enum values for orientation
#4281
+33
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ewen-lbh
requested review from
madskristensen and
hyperupcall
as code owners
|
Thanks for the PR! This section of the codebase is owned by @madskristensen and |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds enum descriptions (with the officially accepted "hack" of turning
enuminto aoneOfofconstsubschemas, see json-schema-org/json-schema-spec#57) to theorientationfield for PWA manifest files. Might do more enums.Main motivation is to show descriptions on auto-complete in IDEs (vscode unfortunately does not show them nicely, i've opened a separate issue microsoft/vscode#236074)
The descriptions are sourced from https://developer.mozilla.org/en-US/docs/Web/Manifest/orientation