Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPX speed and altitude track has incorrect units on x-axis when imperial #328

Closed
jat255 opened this issue Mar 13, 2023 · 2 comments · Fixed by #330
Closed

GPX speed and altitude track has incorrect units on x-axis when imperial #328

jat255 opened this issue Mar 13, 2023 · 2 comments · Fixed by #330
Labels
bug client v0.7.x Issues planned in versions 0.7.x

Comments

@jat255
Copy link
Contributor

jat255 commented Mar 13, 2023

Noticed this today. Here's a plot of speed and elevation from a 3.766 mile walk I recorded:

image

The x-axis goes up to 6.06, which happens to be exactly the distance of the walk in kilometers, so it looks like it's not labeling correctly based on the user setting.

If I switch my profile to use metric units, everything looks good:

image

If I had to take a guess, I think this isn't working because of this line in workouts.ts: https://github.com/SamR1/FitTrackee/blob/master/fittrackee_client/src/utils/workouts.ts#L39; It looks like that rather than data.distance, it should be convertStatsDistance('km', data.distance, useImperialUnits), but this is just from inspecting the code, so I haven't tested that.

@SamR1
Copy link
Owner

SamR1 commented Apr 5, 2023

thanks for the issue and the PR.

@SamR1 SamR1 added this to the v0.7 - OAuth 2.0 milestone Apr 8, 2023
@SamR1 SamR1 added bug client v0.7.x Issues planned in versions 0.7.x labels Apr 8, 2023
@SamR1
Copy link
Owner

SamR1 commented Apr 12, 2023

released in v0.7.15

@SamR1 SamR1 closed this as completed Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug client v0.7.x Issues planned in versions 0.7.x
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants