Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link wrapping an image does not get focus styling on GlobalHeader #6890

Open
1 task done
johnb-sage opened this issue Aug 8, 2024 · 5 comments
Open
1 task done

Comments

@johnb-sage
Copy link

Description

An image wrapped in Link (e.g. a logo) is not styled when focused on GlobalHeader.

Reproduction

https://stackblitz.com/edit/parsium-carbon-starter-hfnajo?file=src%2FApp.tsx

Steps to reproduce

Tab to the Logo, no focus styling is applied.

Also note the focus styling on the text link, seems that box shadow is being incorrectly applied.

JIRA ticket numbers (Sage only)

No response

Suggested solution

No response

Carbon version

141.4.4

Design tokens version

No response

Relevant browsers

Chrome

Relevant OSs

MacOS

Additional context

No response

Confidentiality

  • I confirm there is no confidential or commercially sensitive information included.
@johnb-sage johnb-sage added Bug triage Triage Required labels Aug 8, 2024
@Parsium
Copy link
Contributor

Parsium commented Aug 13, 2024

Thanks for raising this @johnb-sage 👍🏼

May I check what styling you expect to see when the logo in the demo is focused? Have you received any specific designs for this? We assume the logo would require the standard gold focus ring, similar to this example:

Screenshot 2024-08-13 at 15 08 26

@johnb-sage
Copy link
Author

johnb-sage commented Aug 13, 2024

@Parsium I feel GlobalHeader wouldn't comfortably support the double focus ring. Since space is tight in this case a much thinner focus style might be more appropriate?

@nineteen88
Copy link
Contributor

@harpalsingh Hey, would you be able to take a look at this and advise on what the focus border should look like. Thanks!

@harpalsingh
Copy link
Member

@nineteen88 yep so this is the expectation of the focus on a logo visula, so its an internal version of the double border:

Screenshot 2024-09-04 at 11 24 13

@nineteen88
Copy link
Contributor

FE-6802

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

4 participants