Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: index tensor on cpu #961

Merged
merged 5 commits into from
Nov 26, 2024
Merged

fix: index tensor on cpu #961

merged 5 commits into from
Nov 26, 2024

Conversation

lars-reimann
Copy link
Member

@lars-reimann lars-reimann commented Nov 26, 2024

Summary of Changes

The index tensor of an ImageDataset sometimes ended up on the CPU, instead of the default device, which led to runtime errors. This PR fixes this.

Verified

This commit was signed with the committer’s verified signature.
lars-reimann Lars Reimann
A `torch.LongTensor` seems to always be created on the CPU.
@lars-reimann lars-reimann requested a review from a team as a code owner November 26, 2024 15:49

Verified

This commit was signed with the committer’s verified signature.
lars-reimann Lars Reimann
The result is not great with 32 epochs, either.
@lars-reimann lars-reimann force-pushed the fix-index-tensor-on-cpu branch from 1dfa9f1 to 58b0067 Compare November 26, 2024 15:50

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Copy link
Contributor

github-actions bot commented Nov 26, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON black 3 0 0 0.69s
✅ PYTHON mypy 3 0 2.9s
✅ PYTHON ruff 3 0 0 0.06s
✅ REPOSITORY git_diff yes no 0.07s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

Verified

This commit was signed with the committer’s verified signature.
lars-reimann Lars Reimann

Verified

This commit was signed with the committer’s verified signature.
lars-reimann Lars Reimann
@lars-reimann lars-reimann merged commit afafd43 into main Nov 26, 2024
9 checks passed
@lars-reimann lars-reimann deleted the fix-index-tensor-on-cpu branch November 26, 2024 16:13
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.42%. Comparing base (5b32acc) to head (632cf54).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #961      +/-   ##
==========================================
- Coverage   94.42%   94.42%   -0.01%     
==========================================
  Files         121      121              
  Lines        7462     7461       -1     
==========================================
- Hits         7046     7045       -1     
  Misses        416      416              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

lars-reimann pushed a commit that referenced this pull request Nov 26, 2024
## [0.29.0](v0.28.1...v0.29.0) (2024-11-26)

### Features

* remove `Image.__array__` ([#964](#964)) ([d2f59c9](d2f59c9))
* rename `count_row_if` to `count_rows_if` ([#960](#960)) ([f5d6324](f5d6324))
* rename `epoch_size` to `epoch_count` ([#962](#962)) ([fa62e9b](fa62e9b))
* rename `flip_vertically` and `flip_horizontally` methods ([#946](#946)) ([a3607d7](a3607d7)), closes [#945](#945)
* rename `load_pretrained_model` to `from_pretrained_model` ([#957](#957)) ([5b32acc](5b32acc))
* rename `Row.get_value` to `Row.get_cell` ([#947](#947)) ([e77cb6c](e77cb6c))

### Bug Fixes

* avoid performance warning when accessing `column_count` ([#949](#949)) ([c24b6d5](c24b6d5))
* handle deprecations in third-party libraries ([#963](#963)) ([e10e6bb](e10e6bb))
* index tensor on cpu ([#961](#961)) ([afafd43](afafd43))
@lars-reimann
Copy link
Member Author

🎉 This PR is included in version 0.29.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Included in a release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant