Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BufferMaker is not longer maintained #1332

Open
Sarazh opened this issue Sep 24, 2019 · 1 comment
Open

BufferMaker is not longer maintained #1332

Sarazh opened this issue Sep 24, 2019 · 1 comment

Comments

@Sarazh
Copy link

Sarazh commented Sep 24, 2019

BufferMaker is marked as not longer maintained and raises DeprecationWarning: Buffer() is deprecated due to security and usability issues. refer to Nodejs buffer constructor deprecation
May you consider using other package instead? or taking over the maintenance?

Environment

  • Node version: 10.16.3
  • Kafka-node version: 4.1.1
@jwulf
Copy link

jwulf commented Mar 9, 2020

Buffermaker is breaking kafka-node's interoperability with other packages in the ecosystem, particularly with Zeebe's Node client. See camunda-community-hub/zeebe-client-node-js#124

Buffermaker has a strict version dependency in it:

"dependencies": {
    "long": "1.1.2"
  },

This breaks gRPC, if kafka-node is installed before the gRPC package that is a dependency of zeebe-node.

The fix for that may be as simple as forking, unlocking the dependency, publishing a package with a more relaxed semver, and depending on that for kafka-node.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants