Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI should check more than just --release #40

Closed
LegNeato opened this issue Oct 21, 2024 · 1 comment
Closed

CI should check more than just --release #40

LegNeato opened this issue Oct 21, 2024 · 1 comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@LegNeato
Copy link
Collaborator

Due to an underlying rustc change when forward porting, building without --release was broken on aarch64 (see #29 and #31). Unfortunately, CI only runs --release so we were blind to this breakage.

While running everything with and without --release is probably not worth the additional CI time, we should have at least one job on each platform that ensures both configs work at a basic level.
@LegNeato LegNeato added good first issue Good for newcomers help wanted Extra attention is needed labels Oct 21, 2024
@zanciks zanciks mentioned this issue Nov 10, 2024
Merged
@LegNeato
Copy link
Collaborator Author

Fixed by #52, thanks @zanciks ! 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@LegNeato