Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Remove openRoom client meteor method #33833

Open
wants to merge 18 commits into
base: develop
Choose a base branch
from
Open

chore: Remove openRoom client meteor method #33833

wants to merge 18 commits into from
+138 −40

Conversation

aleksandernsilva
Copy link
Contributor

@aleksandernsilva aleksandernsilva commented Oct 30, 2024 •
edited by jira bot
Loading

Proposed changes (including videos or screenshots)

This PR removes openRoom meteor method both on client and server.

Issue(s)

ARCH-1341

Steps to test or reproduce

Further comments

@dionisio-bot dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Oct 30, 2024 •
edited
Loading

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 30, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 4cb007f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 30, 2024 •
edited
Loading

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33833/
on branch gh-pages at 2024-12-13 23:36 UTC

@codecov Codecov
Copy link

codecov bot commented Oct 30, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.79%. Comparing base (85980d7) to head (4cb007f).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #33833   +/-   ##
========================================
  Coverage    75.79%   75.79%           
========================================
  Files          511      511           
  Lines        22132    22132           
  Branches      5394     5394           
========================================
  Hits         16775    16775           
  Misses        4709     4709           
  Partials       648      648
Flag Coverage Δ
unit 75.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@aleksandernsilva aleksandernsilva force-pushed the chore/remove-openroom-method branch from 80e6842 to 95f3ac6 Compare October 30, 2024 13:15
debdutdeb
debdutdeb previously requested changes Oct 31, 2024
View reviewed changes
Copy link
Member

@debdutdeb debdutdeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comments above

@aleksandernsilva aleksandernsilva force-pushed the chore/remove-openroom-method branch from 26e810e to cca3e77 Compare November 21, 2024 19:57
@aleksandernsilva aleksandernsilva marked this pull request as ready for review November 22, 2024 00:31
@aleksandernsilva aleksandernsilva requested review from a team as code owners November 22, 2024 00:31
@aleksandernsilva aleksandernsilva added this to the 7.2.0 milestone Nov 22, 2024
@aleksandernsilva aleksandernsilva changed the title chore: Remove openRoom meteor method chore: Remove openRoom client meteor method Nov 22, 2024
@aleksandernsilva aleksandernsilva force-pushed the chore/remove-openroom-method branch from b7cab56 to c2f7ea7 Compare November 22, 2024 13:48
dougfabris
dougfabris previously approved these changes Nov 25, 2024
View reviewed changes
Copy link
Member

@dougfabris dougfabris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

tassoevan
tassoevan previously approved these changes Dec 5, 2024
View reviewed changes
@aleksandernsilva aleksandernsilva marked this pull request as draft December 5, 2024 13:16
@aleksandernsilva aleksandernsilva marked this pull request as ready for review December 5, 2024 14:58
tassoevan
tassoevan previously approved these changes Dec 5, 2024
View reviewed changes
@aleksandernsilva aleksandernsilva marked this pull request as draft December 5, 2024 17:13
@aleksandernsilva aleksandernsilva force-pushed the chore/remove-openroom-method branch from 9c0e3b5 to a90550c Compare December 6, 2024 21:57
@aleksandernsilva aleksandernsilva marked this pull request as ready for review December 9, 2024 12:34
@aleksandernsilva aleksandernsilva requested a review from a team as a code owner December 9, 2024 12:34
@aleksandernsilva aleksandernsilva dismissed debdutdeb’s stale review December 10, 2024 16:34

All requested changes have been addressed

@tassoevan tassoevan added the stat: QA assured Means it has been tested and approved by a company insider label Dec 12, 2024
@aleksandernsilva @tassoevan
chore: remove openRoom client meteor method
0f3b6df
@aleksandernsilva @tassoevan
refactor: review requests
45971af
@aleksandernsilva @tassoevan
feat: added optmistic update
d92dd42
@aleksandernsilva @tassoevan
chore: removed rooms.open endpoint
6a36475
@aleksandernsilva @tassoevan
refactor: use open endpoints based on room type
835a280
@aleksandernsilva @tassoevan
fix: included voip rooms as valid in channels.open
4cc245d
@aleksandernsilva @tassoevan
chore: adjusted import order
0dfb946
@aleksandernsilva @tassoevan
refactor: changed to use updateSubscription
829bf6e
@aleksandernsilva @tassoevan
chore: implemented InvalidUserError
2cfc112
@aleksandernsilva @tassoevan
refactor: early throw if user is invalid
2dab2a3
@aleksandernsilva @tassoevan
chore: removed InvalidUserError
8bac5fc
@aleksandernsilva @tassoevan
refactor: removed throw and added userId as required param
b273dea
@aleksandernsilva @tassoevan
feat: added rooms.open endpoint
3a2a0e0
@aleksandernsilva @tassoevan
refactor: useOpenRoomMutation to use rooms.open endpoint
ebbe347
@aleksandernsilva @tassoevan
chore: removed methods import
9c2d0b8
@aleksandernsilva @tassoevan
chore: revert channels restriction
de3da92
@aleksandernsilva @tassoevan
chore: added minLength
f3545a9
@aleksandernsilva @tassoevan
test: added subscription assertion
4cb007f
@tassoevan tassoevan force-pushed the chore/remove-openroom-method branch from 9c76a55 to 4cb007f Compare December 13, 2024 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yash-rajpal yash-rajpal yash-rajpal left review comments

@KevLehman KevLehman KevLehman left review comments

@MarcosSpessatto MarcosSpessatto MarcosSpessatto approved these changes

@tassoevan tassoevan tassoevan approved these changes

@dougfabris dougfabris dougfabris left review comments

@debdutdeb debdutdeb Awaiting requested review from debdutdeb

Assignees
No one assigned
Labels
stat: QA assured Means it has been tested and approved by a company insider
Projects
None yet
Milestone
7.2.0
Development

Successfully merging this pull request may close these issues.
7 participants
@aleksandernsilva @tassoevan @KevLehman @MarcosSpessatto @dougfabris @yash-rajpal @debdutdeb