Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add announcements #257

Open
wants to merge 132 commits into
base: dev
Choose a base branch
from
Open

Conversation

madkarmaa
Copy link
Member

@madkarmaa madkarmaa commented Sep 8, 2024

What's this?

This is a new, more updated continuation of #195

TODO:

  • Footer shifts up when content is little Out of scope of this PR
  • When inside an announcement (/announcement/X) make clicking on the nav tab "Announcement" go back
  • Handle nullable properties of announcement object
  • Settings dialog needs to be redesigned (Move login dialog stuff into the settings dialog) This is too big of a feat for this due to spaghetti code, it should be part of the major rewrite
  • Action buttons in announcement for admins need to be img wrapped in buttons
  • Removing tags in announcement when editing it should be done by simply clicking on the tag
  • Adding attachments should behave the same as adding tags
  • If attachment URLs are empty, prevent saving the announcement edit
  • In edit announcement fields null can not be expressed (For example the author field left empty saves an empty string in API)
  • Attachment textbox string overflows into bin icon
  • In mobile view the separators should be full width
  • Title is not nullable, but an announcement can still be created with an empty title
  • If a date is near the current one, it should be displayed in relative time (For example when the announcement was just created
  • Text should not be red in the "Expired login" dialog
  • Switch date in footer with content in header
  • Inspecting the network tab, query is making fetches every couple of seconds for individual announcements for no reason
  • Enter button to submit login in login dialog doesn't work
  • Creating a new announcement/updating it does not update it in the "announcements" page unless you refresh the page (Cache problem?)
  • The plus icon in the create announcement button is not dark

@madkarmaa madkarmaa self-assigned this Sep 8, 2024
@oSumAtrIX oSumAtrIX mentioned this pull request Sep 8, 2024
5 tasks
@Ushie Ushie changed the title feat: announcements feat: Announcements Sep 8, 2024
@Ushie Ushie requested a review from oSumAtrIX December 4, 2024 12:43
@Ushie Ushie marked this pull request as ready for review December 5, 2024 00:01
@Ushie Ushie force-pushed the feat/announcements branch from 1e19a0d to d9c7a4a Compare December 5, 2024 00:33
@oSumAtrIX oSumAtrIX changed the title feat: Announcements feat: Add announcements Dec 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants