Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workspace versions/metadata inheritance support #1130

Closed
messense opened this issue Sep 25, 2022 · 1 comment · Fixed by #1131
Closed

workspace versions/metadata inheritance support #1130

messense opened this issue Sep 25, 2022 · 1 comment · Fixed by #1131
Labels
enhancement New feature or request

Comments

@messense messense added the enhancement New feature or request label Sep 25, 2022
@messense
Copy link
Member Author

// Those three fields are mandatory
// https://doc.rust-lang.org/cargo/reference/manifest.html#the-package-section
pub(crate) name: String,
pub(crate) version: String,
// All other fields are optional
pub(crate) authors: Option<Vec<String>>,
pub(crate) description: Option<String>,
pub(crate) documentation: Option<String>,
pub(crate) homepage: Option<String>,
pub(crate) repository: Option<String>,
pub(crate) readme: Option<String>,
pub(crate) keywords: Option<Vec<String>>,
pub(crate) categories: Option<Vec<String>>,
pub(crate) license: Option<String>,

I think rather than parsing the Cargo.toml by our self, read the standard Cargo metadata fields from cargo metadata output should give us workspace inheritance support for free.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant