Docstring may also be prefixed with U and R.

[xuhdev]

No description provided.

[FichteFoll]

Also just f. (apparently not)

[asottile]

russian strings (ru'foo') are not valid -- could you also add a test case to demonstrate your change while you're at it -- thanks!

$ python2
Python 2.7.15+ (default, Nov 27 2018, 23:36:35) 
[GCC 7.3.0] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> ru'foo'
  File "<stdin>", line 1
    ru'foo'
          ^
SyntaxError: invalid syntax
>>> 
$ python3
Python 3.6.8 (default, Jan 14 2019, 11:02:34) 
[GCC 8.0.1 20180414 (experimental) [trunk revision 259383]] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> ru'foo'
  File "<stdin>", line 1
    ru'foo'
          ^
SyntaxError: invalid syntax

[sigmavirus24]

@xuhdev I'm looking at the PR diff here and am not seeing a test or change that matches what @asottile asked for

[xuhdev]

I updated the PR. I'm not sure how to add relevant test though; pycodestyle does not appear to check specifically for string prefixes.

[asottile]

I updated the PR. I'm not sure how to add relevant test though; pycodestyle does not appear to check specifically for string prefixes.

I'm not sure what this PR fixes then -- did you have a particular case where this fixed something?

I was able to debug what this is intended to protect against (I think?)

--- a/pycodestyle.py
+++ b/pycodestyle.py
@@ -374,6 +374,9 @@ def blank_lines(logical_line, blank_lines, indent_level, line_number,
                     previous_indent_level < indent_level or
                     DOCSTRING_REGEX.match(previous_logical)
                     ):
+
+                if not DOCSTRING_REGEX.match(previous_logical):
+                    breakpoint()
                 ancestor_level = indent_level
                 nested = False
                 # Search backwards for a def ancestor or tree root

this is hit for the following testcase from the testsuite:

class X:

    def a():
        pass
    def b():
        pass

Adjusting this slightly:

class X:

    def a():
        """docstring"""
    def b():
        pass

that passes with no errors:

$ python3.7 -m pycodestyle t.py
$

But, if we adjust it:

class X:

    def a():
        U"""docstring"""
    def b():
        pass

$ python3.7 -m pycodestyle t.py
t.py:5:5: E301 expected 1 blank line, found 0

You can probably use this difference to write a testcase I imagine?