Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent E127 in generator expression used as argument #904

Closed
anntzer opened this issue Jan 21, 2020 · 2 comments
Closed

Inconsistent E127 in generator expression used as argument #904

anntzer opened this issue Jan 21, 2020 · 2 comments

Comments

@anntzer
Copy link
Contributor

anntzer commented Jan 21, 2020

As of pycodestyle 2.5.0

(x for x in container
 if somecond(x)
    and othercond(x))

generates no warning (which I think is correct) whereas

sorted(x for x in container
       if somecond(x)
          and othercond(x))

results in an (IMO incorrect) "E127 continuation line over-indented for visual indent".

@asottile
Copy link
Member

(I can't edit since I'm not part of the project) -- could you fix the title to reference E131 instead of E127?

this is also a duplicate of #680 which (lol) you reported :)

@anntzer anntzer changed the title Inconsistent E131 in generator expression used as argument Inconsistent E127 in generator expression used as argument Jan 21, 2020
@anntzer
Copy link
Contributor Author

anntzer commented Jan 21, 2020

lol, I searched for E131 and didn't find anything, even though I had a very clear feeling that I had already seen this before, sorry for the noise :p

@anntzer anntzer closed this as completed Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants