fix hitbox issues on newer versions of minecraft #116
Conversation
|
thoughts @IceTank ? |
|
@SilkePilon Did you base these changes on any differences you found between the current prismarine-physics code and the Java code? This might trigger anti cheat plugins if horizontal collisions don't line up anymore between Java and prismarine-physics. |
| @@ -115,7 +115,7 @@ function Physics (mcData, world) { | |||
| if (block) { | |||
| const blockPos = block.position | |||
| for (const shape of block.shapes) { | |||
| const blockBB = new AABB(shape[0], shape[1], shape[2], shape[3], shape[4], shape[5]) | |||
| const blockBB = new AABB(shape[0] - 0.01, shape[1], shape[2] - 0.01, shape[3] + 0.01, shape[4], shape[5] + 0.01) | |||
There was a problem hiding this comment.
Can you add a comment explaining why the bounding box is increased here?
Also, this check now applies for all versions. It might be better to do this version specific. As far as I know, it was working fine in older versions of the game.
|
I made this change at a recommendation of vakore on Discord. Apparently the current system isn't perfect at handling hitbox's. As sometimes the hitbox ends up inside a block and makes the bot unable to move by extending the hitbox a bit this fixes the issue sometimes. Tho it's not a perfect solution and more of a "hack". |
In newer versions of minecraft there are some minor changes to the hitbox system
this wont affect older versions.
examples of the bug:
