dnsdist: cannot run dnsdist regression tests with python3.13+

[karelbilek]

• This is not a support question, I have read about opensource and will send support questions to the IRC channel, GitHub Discussions or the mailing list.
• I have read and understood the 'out in the open' support policy

• Program: dnsdist
• Issue type: Bug report

Short description

I cannot run dnsdist regression tests.

It seems to be caused by this issue.

jnwatson/py-lmdb#362

Environment

• Operating system: macOS
• Software version: master
• Software source: github

Steps to reproduce

1. clone pdns
2. go to ./regression-tests.dnsdist
3. ./runtests

Expected behaviour

Tests will work

Actual behaviour

Tests end with

      lmdb/cpython.c:548:12: error: call to undeclared function 'PyObject_AsReadBuffer'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
        548 |     return PyObject_AsReadBuffer(buf,
            |            ^
      1 error generated.
      error: command '/usr/bin/clang' failed with exit code 1
      [end of output]

Other information

It seems to be caused by some third party dependency (lmdb) using a deprecated call that was removed in new python. I did not yet try to use an older python version.

[karelbilek]

using python 3.11 fixes the issue.

[rgacogne]

FWIW 3.12.7 works as well. I'm not sure what we can do about it, a new release of py-lmdb would be great.

[karelbilek]

I suggest keeping the issue open for others to see it/track it, and you can close it with new py-lmdb?

[karelbilek]

I was thinking this could be fixed with adding Dockerfile and putting all the tests to Docker with fixed Python version; but it would be a bit of a rewrite, to access the built binary there. Do you think it's worth it?

[rgacogne]

Thank you, but I don't think this is a good idea. I actually want the tests to break when something we rely on breaks, so that we know about it. Otherwise I'll learn about it much later, worst case scenario when something breaks in production.