css not inlined on windows7 @0.5.0

[ulybu]

The css linked in my seed-element.html is not inlined in my vulcanized output.

• Only on windows 7 and vulcanize 0.5.0 and 0.6.1 (I guess 0.6.0 too).
• Works fine on Mac or on windows with [email protected]

I may be missing some options, but the result should be the same on both platform

How to reproduce

1. clone https://github.com/ulybu/vulcanize-no-css
2. bower install
3. vulcanize --inline seed-element.html
4. run index.html on a webserver

result

C:\Users\prygiel\CODE\svnhp>npm list -g vulcanize
C:\Users\prygiel\AppData\Roaming\npm
└── [email protected]

[ebidel]

Weird. This also works fine for me on Mac, vulcanize 0.6.1. Can you attach the vulccanized.html? 0.6.1 does the same thing?

[ragingwind]

@ebidel I confirmed through this test code. [email protected] version (via npm) was not return correctly list called by $('link[rel="stylesheet"]') method. all returned list count is zero. howerver, I could get a result what I expected when I tested with previous tarball version(v0.1.3.2). I guess, whacko would be changed something. see log below

~/Workspace/wakr/chromeapps-starter-kit [prototype]✎ ragingwind@rw-mbprt 0.2168s
❯ npm install https://github.com/inikulin/whacko/archive/v0.13.2.tar.gz
[email protected] node_modules/whacko
├── [email protected]
├── [email protected]
├── [email protected]
└── [email protected] ([email protected], [email protected])

~/Workspace/wakr/chromeapps-starter-kit [prototype]✎ ragingwind@rw-mbprt 5.2466s
❯ node whacko-test.js
readfile: app/components/core-scaffold/core-scaffold.html link: 0
readfile: app/components/core-toolbar/core-toolbar.html link: 1
readfile: app/components/core-header-panel/core-header-panel.html link: 1
readfile: app/components/core-menu/core-menu.html link: 1
readfile: app/components/core-item/core-item.html link: 1
readfile: app/components/core-iconset-svg/core-iconset-svg.html link: 0

~/Workspace/wakr/chromeapps-starter-kit [prototype]✎ ragingwind@rw-mbprt 0.0580s
❯ npm install whacko
[email protected] node_modules/whacko
├── [email protected]
├── [email protected]
├── [email protected] ([email protected])
└── [email protected] ([email protected], [email protected])

~/Workspace/wakr/chromeapps-starter-kit [prototype]✎ ragingwind@rw-mbprt 3.7312s
❯ node whacko-test.js [LINK COUNT ALL IS ZERO]
readfile: app/components/core-scaffold/core-scaffold.html link: 0 
readfile: app/components/core-toolbar/core-toolbar.html link: 0
readfile: app/components/core-header-panel/core-header-panel.html link: 0
readfile: app/components/core-menu/core-menu.html link: 0
readfile: app/components/core-item/core-item.html link: 0
readfile: app/components/core-iconset-svg/core-iconset-svg.html link: 0

[ragingwind]

They updated parse5 version. inikulin/whacko@378a14d#diff-b9cfc7f2cdf78a7f4b91a753d10865a2L30

[ulybu]

I pushed both vulcanized files (osx and win) : https://github.com/ulybu/vulcanize-no-css

Yes the problem is still there with 0.6.1.

[inikulin]

Guys, this issue is caused by recently landed full-featured <template> support in both parse5 and whacko. According to spec <template> content is wrapped into document fragment element. Therefore it can't be directly queried (see: inikulin/parse5#23 (comment)). So this requires fix on vulcanize side. I suggest you to lock down version of the whacko to 0.17.1 (which is always a good idea) until the dust settles.

[ebidel]

Ugh. That's no good. Thanks for tracking this down.

[dfreedm]

Fixed with 529620e. @inikulin I'm not sure that <template> support was only worth a .z bump, since it was a pretty big parsing change. Regardless, I started working on supporting <template> correctly, and released 0.6.2 to stay at whacko 0.17.1 until I finish.

[inikulin]

I'm not sure that support was only worth a .z bump, since it was a pretty big parsing change.
@azakus Sure. Sorry for this. I was focused on keeping version in sync with the upstream repo and didn't get in consideration that it may break dependents.