Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for unused goldens in CI #389

Closed
L-as opened this issue Mar 18, 2022 · 1 comment
Closed

Check for unused goldens in CI #389

L-as opened this issue Mar 18, 2022 · 1 comment
Assignees
@srid
Labels
testing

Comments

@L-as
Copy link
Member

L-as commented Mar 18, 2022

No description provided.

@L-as L-as mentioned this issue Mar 18, 2022
Merged
5 tasks
@srid srid added the testing label Mar 18, 2022
@srid srid self-assigned this Mar 18, 2022
@srid srid mentioned this issue Mar 18, 2022
Closed
@srid
Copy link
Member

srid commented Mar 18, 2022 •
edited
Loading

The spec hierarchy can be used to determine "used" goldens automatically, except for the manually created goldens:

fromList ["goldens/scripts.auth_policy.hash.golden","goldens/scripts.auth_stake_validator.hash.golden","goldens/scripts.auth_validator.hash.golden"]

EDIT: will just consolidate these into the general goldens using pconstant on the hash value.

@srid srid mentioned this issue Mar 18, 2022
Merged
@TotallyNotChase TotallyNotChase linked a pull request Mar 21, 2022 that will close this issue
Plutarch 1.2 #317
Merged
@L-as L-as removed a link to a pull request Apr 19, 2022
Plutarch 1.2 #317
Merged
@L-as L-as closed this as completed Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@srid srid

Labels
testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@srid @L-as