Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autodesk: Vulkan and Metal round points #3463

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from

Conversation

erikaharrison-adsk
Copy link
Contributor

@erikaharrison-adsk erikaharrison-adsk commented Dec 12, 2024

Description of Change(s)

  • Add shader fragments to assign a round sample mask on points for Hgi implementations that don't support natively rasterizing round points (all modern APIs basically).
  • Was originally targeting HgiVulkan, but implemented the feature at the Hgi level, so also made the necessary changes for HgiMetal.
  • Add the setting HGIVULKAN_PREFERRED_DEVICE_TYPE which takes a VkPhysicalDeviceType enum int value and can be used to select between different GPUs. I needed this to test with Intel integrated graphics, which support up to 16x MSAA (instead of my default dedicated Nvidia GPU).
  • Add the setting HDX_MSAA_SAMPLE_COUNT to set the MSAA sample count. Use 1 to disable MSAA. Needed this to test different sample count results.

Link to proposal (if applicable)

  • N/A

Fixes Issue(s)

  • N/A

Checklist

@jesschimein
Copy link
Collaborator

Filed as internal issue #USD-10507

(This is an automated message. See here for more information.)

@jesschimein
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants