-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
compute_mean_speed_per_frame return a pandas.series instead of a pandas.dataframe #362
Comments
Should we convert it to DataFrame?
|
That's what I did in my code but I think it's worth looking at the code see if this fix is appropriate |
Just a reminder, changing the return type is a breaking change. If you want to change the return type, the old should still be available. But why do you want to have a dataframe? It only consists of an index (frame) and a value, this is the use case for series |
Because the documentation of the function says that it returns a dataframe. |
The documentation seems to be off in this case. I suggest checking what the other functions return, from the documentation |
I'll check this and I think it's better to change the documentation than to add breaking code changes |
No description provided.
The text was updated successfully, but these errors were encountered: