Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Puny Code Error #1547

Closed
palisadoes opened this issue Dec 23, 2023 · 6 comments
Closed

Fix Puny Code Error #1547

palisadoes opened this issue Dec 23, 2023 · 6 comments
Assignees
Labels
bug Something isn't working wontfix This will not be worked on

Comments

@palisadoes
Copy link
Contributor

Describe the bug
Whenever the API is started or a commit is made there is a Puny Code deprecation error

To Reproduce
Steps to reproduce the behavior:

  1. Start API or,
  2. Commit code

Expected behavior

  1. Fix the Puny Code requirement IF IT IS being used by the application
  2. The removal of the Puny Code requirement IF IT IS NOT being used. This would include removing it from the package.json file
  3. All tests must pass
  4. No app functionality must be affected

Actual behavior

  • See above

Screenshots
image

Additional details

  • N/A

Potential internship candidates
Please read this if you are planning to apply for a Palisadoes Foundation internship

@palisadoes palisadoes added the bug Something isn't working label Dec 23, 2023
@github-actions github-actions bot added the unapproved Unapproved for Pull Request label Dec 23, 2023
@imshivam-gupta
Copy link

@palisadoes Can I work on this issue?

@Cioppolo14 Cioppolo14 removed the unapproved Unapproved for Pull Request label Dec 24, 2023
@imshivam-gupta
Copy link

@palisadoes, I have observed that the PunyCode module has been deprecated in Node.js version 21.5. This poses an issue as it is utilized by the fast-url-parser library, which, in turn, is a dependency of @graphql-tools. Unfortunately, fast-url-parser is not actively maintained, and there is already an open issue regarding this matter - Link.

Presently, we find ourselves with two potential courses of action:

  1. Wait for the next release of @graphql-tools and, in the meantime, switch to Node.js version 18.
  2. Explore alternatives to @graphql-tools, although this is not a preferred option given its status as a well-maintained repository.

Your insights on this matter would be greatly appreciated.

@palisadoes
Copy link
Contributor Author

  1. The first option.
  2. Add the recommendation to INSTALLATION.md that the preferred node version is at least v18 as part of the PR. There is a node section in that document that would be suitable

@palisadoes
Copy link
Contributor Author

palisadoes commented Dec 24, 2023

Hold on. Why upgrade to node v18? It is not related to this issue of fixing the Puny Code Error

@imshivam-gupta
Copy link

imshivam-gupta commented Dec 24, 2023

I found online that the deprecation warning for Punycode appeared after Node v18. The API worked perfectly with v18, and in all the GitHub discussions I read, a common solution was identified.
Puny Code warning is coming because of @graphql/tools dependency.

@palisadoes palisadoes added the wontfix This will not be worked on label Dec 24, 2023
@palisadoes
Copy link
Contributor Author

  1. Upgrading to node v18 ignores the problem, it doesn't solve it.
  2. I'd prefer to focus on making the Talawa typescript repositories support the latest LTS versions of node
  3. I'll close this issue as "will not fix" and the PR too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working wontfix This will not be worked on
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants