Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for "frame" argument in "COMMAND_INT" version of MAV_CMD_DO_REPOSITION #8502

Closed
shylent opened this issue Dec 20, 2017 · 3 comments

Comments

@shylent
Copy link

shylent commented Dec 20, 2017

MAV_CMD_DO_REPOSITION works as documented (in http://mavlink.org/messages/common) when used as COMMAND_LONG. However, COMMAND_INT has a frame argument, which could apply to this command:

  • if user specifies MAV_FRAME_GLOBAL_RELATIVE_ALT_INT (6), param7 (altitude) is interpreted as relative to home position
  • if user specifies MAV_FRAME_GLOBAL_INT (5), param7 (altitude) is interpred as AMSL (same as with the COMMAND_LONG version)

Right now, altitude is always interpreted as AMSL, which can be worked around if one wants to work in terms of relative altitude, but such workaround seems to be quite indirect.

I've worked around it as follows (ROS-specific stuff follows, sorry): I need to reposition to some relative altitude Z. I take relative altitude from /mavros/altitude, subtract it from AMSL altitude from the same /mavros/altitude thus getting the offset between the two (or, alternatively, the AMSL altitude of the home point). Adding the offset to Z, I get its AMSL equivalent.

@dagar
Copy link
Member

dagar commented Dec 20, 2017

This might be a good excuse to generalize MAV_FRAME (https://mavlink.io/en/messages/common.html#MAV_FRAME) usage across navigator.

It would make DO_REPOSITION more useful, and it's a stepping stone to local coordinate frame mission support. @Stifael FYI

@stale
Copy link

stale bot commented Jan 29, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale
Copy link

stale bot commented Feb 19, 2019

Closing as stale.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants