Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any chance of a tagged release for PHP 8 support? #15

Closed
alistair-soreal opened this issue Sep 23, 2021 · 11 comments
Closed

Any chance of a tagged release for PHP 8 support? #15

alistair-soreal opened this issue Sep 23, 2021 · 11 comments
Labels
question Further information is requested

Comments

@alistair-soreal
Copy link

Hi there

Thanks for your great work in getting this package modernized, do you have a tagged release coming out as I can't really use dev-develop as a security policy, I've forked for now but would like to stay current with they work you are doing in the future.

Many thanks!

@Messhias
Copy link
Collaborator

Hi there

Thanks for your great work in getting this package modernized, do you have a tagged release coming out as I can't use dev-develop as a security policy, I've forked for now but would like to stay current with the work you are doing in the future.

Many thanks!

Hi, we forked the package and we're keeping it updated you can use our and put your thoughts, issues, PR's and we're checking it daily basis.

We're checking the actual opened PR's on the original fork to see what we can migrate or not, for now, we're trying to work to release a new version at the master by the end of the month, but since now only I and @eschricker is working on that, if you want to help us to contribute and keep the package going forward would be great.

@Messhias Messhias added the question Further information is requested label Sep 23, 2021
@Alrod8901
Copy link

Hi guys,
First of all, thank you for the work you are doing to recover this important project and I hope that many more will come later.
Is there progress in having a tagged release compatible with php ^8 out of the development branch?

@IlyaVorozhbit
Copy link

@Alrod8901 it seems the author hasn't answering for a couple of weeks. It is very sad

@eschricker
Copy link
Contributor

We are currently in the process of migrating the PRs from the original project. We are on a good way. I think we will be able to create a tagged version early next week.

@djereg
Copy link

djereg commented Oct 8, 2021

It wouldn't be bad that when you forked the repository and changed all the important things (like the nemaspaces), then release 1.0.0 because the package works perfectly. And after the successfully migrated and merged pull requests you release another versions. Because impatient people can’t wait. I'm one of them 😄

Not safe, but currently I use dev-develop, because as I said, it's a working package.

@Messhias
Copy link
Collaborator

Messhias commented Oct 8, 2021

It wouldn't be bad that when you forked the repository and changed all the important things (like the namespaces), then release 1.0.0 because the package works perfectly. And after the successfully migrated and merged pull requests you release another version. Because impatient people can’t wait. I'm one of them 😄

Not safe, but currently I use dev-develop, because as I said, it's a working package.

Hi, I could understand that impatient people can't wait (I'm one of these too) but as you see we already have some opened PR's and we're facing issues to adapt the unit tests for the new scenarios and would be nice if you could help us with that.

About the release, well, I believe we should stop using this in the dev-develop stage and start doing more serious deployment because if we follow the road of the old package there's no point to change to it at all (even that the old one becomes quite outdated).

Anyway, I believe with more people helping us out more effective will be the evolve of the package and more quickly we'll release new versions and start having progress.

@IlyaVorozhbit
Copy link

Why just not use tymondesigns/jwt-auth#2117 this PR?

@eschricker
Copy link
Contributor

@IlyaVorozhbit this PR is already included

@IlyaVorozhbit
Copy link

Thanks, I saw it

@eschricker
Copy link
Contributor

We just released 1.1.0 :)
Feel free to test

@eschricker
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

6 participants