fix: correctly parse weekday ranges that include sunday #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the PR. I will look into it within the next days. I think the problem still persists when using aliases, e.g. sat-sun, right? |
|
I've added another commit which changes the |
P4sca1
changed the title
P4sca1
pushed a commit
that referenced
this pull request
Mar 30, 2023
# [4.0.0-next.3](v4.0.0-next.2...v4.0.0-next.3) (2023-03-30) ### Bug Fixes * correctly parse weekday ranges that include sunday ([#283](#283)) ([2fb78b5](2fb78b5))
|
🎉 This PR is included in version 4.0.0-next.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
P4sca1
pushed a commit
that referenced
this pull request
Mar 30, 2023
# [4.0.0](v3.0.6...v4.0.0) (2023-03-30) ### Bug Fixes * correctly parse weekday ranges that include sunday ([#283](#283)) ([2fb78b5](2fb78b5)) * specify types for legacy support ([7288c13](7288c13)) ### chore * drop support for node14 ([d47ac6a](d47ac6a)) ### Features * esm only build ([58cbdd7](58cbdd7)) ### BREAKING CHANGES * If your environment does not support conditional exports, you have to import the schedulers from cron-schedule/dist/schedulers instead of cron-schedule/schedulers. Signed-off-by: Pascal Sthamer <[email protected]> * Support for node14 is dropped, due to its EOL in the next month and missing ESM module support Signed-off-by: Pascal Sthamer <[email protected]> * The package is now ESM only. A CommonJS or IIFE build is no longer provided. * The minimum required version of Node.js is now 14 * utils are no longer exposed * schedulers are no longer exposed in the default entry point. Import them from `cron-schedule/schedulers/interval-based.js` and `cron-schedule/schedulers/timer-based.js` instead. Signed-off-by: Pascal Sthamer <[email protected]>
|
🎉 This PR is included in version 4.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should solve the issue with parsing ranges like
6-7for the weekday.The tests are passing and with that small post processing of the weekdays element ( modulo + set -> remove duplicates and still have 0-6 ) it should do the exact same thing as before.
It should fix #282