Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

behaviour of find_trees with ottTaxonName #42

Open
kcranston opened this issue Dec 20, 2016 · 2 comments
Open

behaviour of find_trees with ottTaxonName #42

kcranston opened this issue Dec 20, 2016 · 2 comments

Comments

@kcranston
Copy link
Member

What should happen in these two cases:

  • there are multiple ottIDs that match the taxon name (could return additional field with other matching name / ids, or a boolean multiple_matches field)
  • there is no ID that matches the taxon name
@josephwb
Copy link
Member

For ottId a bad id returns:

{"matched_studies": []}

So a bad name should do the same. Or update both to be more explicit.

@kcranston
Copy link
Member Author

Simply returning an empty list doesn't differentiate between "there are no trees for this taxon" and "this taxon does not exist". If that distinction is useful, then we should probably return a 400 for the latter case.

Still open question about what to do in cases where the name matches multiple IDs. Is that an error, too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants