Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardize button styles and behaviour #2212

Open
christad92 opened this issue Jun 19, 2024 · 2 comments · May be fixed by #2266
Open

Standardize button styles and behaviour #2212

christad92 opened this issue Jun 19, 2024 · 2 comments · May be fixed by #2266

Comments

@christad92
Copy link

We need to standardize buttons, styles, and behavior on Lightning and Thunderbolt. This helps to deliver consistency and eliminate bounces/flashes experienced when buttons are pressed on the app. See below for an example of how varying save buttons cause a bounce effect.

https://www.loom.com/share/58feb3af170a42fdbe70a127843bb7cb
@christad92 christad92 changed the title Standardize button width levels Standardize button styles and behaviour on Lightning and Thunderbolt Jun 19, 2024
@PrisionMikeLime
Copy link

Hi, I would like to contribute, and this looks like a great first issue. What is the expected behavior then? Its not FOUC in this case, it's because we receive the response so fast that the button flickers with Saving... information. What is the expected solution for this problem? Also, what is thunderbold?

@christad92
Copy link
Author

Hi, I would like to contribute, and this looks like a great first issue. What is the expected behavior then? Its not FOUC in this case, it's because we receive the response so fast that the button flickers with Saving... information. What is the expected solution for this problem? Also, what is thunderbold?

Hi @PrisionMikeLime, thank you for your interest in this issue.

You're right that this is not FOUC rather it is a collapse and reload effect when the button is pressed because the Save button has a smaller width compared to when the button says Saving.... The objective of this issue is that these buttons have the same width.

Sidenote: Thunderbolt is the billing module for OpenFn and this issue is not dependent on thunderbolt.

@christad92 christad92 changed the title Standardize button styles and behaviour on Lightning and Thunderbolt Standardize button styles and behaviour Jun 27, 2024
@oliveirarleo oliveirarleo linked a pull request Jul 8, 2024 that will close this issue
Open
4 tasks
@github-project-automation github-project-automation bot moved this to New Issues in v2 Jul 29, 2024
@christad92 christad92 mentioned this issue Oct 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
v2
Status: New Issues
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

UI small fixes oliveirarleo/lightning
2 participants
@christad92 @PrisionMikeLime