Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

“Get New Quote” button on the quote view is still not working #5

Open
timburcham opened this issue Jun 17, 2015 · 5 comments
Open

Comments

@timburcham
Copy link

No additional details provided

@MikeLeber117

@ElleSkye117
Copy link

It doesn’t look like the code was ever set up to handle any events generated by the “Get New Quote” button in that quote view.

The problem is that “Get New Quote” button in quote app is not working. It looks like There is an issue with the app itself but I see the app working fine on the website.
here is the config JSON we are passing in.
@"[{"appId": "com_openf2_examples_javascript_quote","manifestUrl": "http://www.openf2.org/Examples/Apps","name": "Quote", "context":{"symbol":"MSFT"}}]”
Is there an event we need to register in the app to know when the user taps on “Get New Quote” button and handle it ?

@timburcham
Copy link
Author

The Container should be marshalling any events sent from the app itself. Assuming that the button is sending an event, here a few places to take a look at to see if the events are flowing through:

https://github.com/OpenF2/iOS-Container/blob/master/F2AppView/F2AppView.m#L291
https://github.com/OpenF2/iOS-Container/blob/master/F2%20Demo/MainViewController.m#L235

@ElleSkye117
Copy link

Hi Tim,

It looks like the "Quote view" is not registering for any events like the Watchlist view is.

I tried registering the quote view using the same string as the watchlit view.
F2.Events.on(F2.Constants.Events.APP_SYMBOL_CHANGE, function(data){sendMessageToNativeMobileApp('appsymbolchange',data.symbol)});

This does not seem to cause the quote box to alert the app of the quote changing. No call backs come to the app when trying to "Get New Quote". the "goForSymbol:" method is never called.

@timburcham
Copy link
Author

@MikeLeber117 : given OpenF2/F2#258, could you take a look and see if this is now working?

@ElleSkye117
Copy link

Hi @timburcham I do not see the change working. It looks like the manifest URL is pointing to a different version of appclass.js

Here is the URL the app is using to get those js files.
http://www.openf2.org/Examples/Apps/json?params=%5B%7B%22appId%22:%20%22com_openf2_examples_javascript_quote%22,%22manifestUrl%22:%20%22http://www.openf2.org/Examples/Apps%22,%22name%22:%20%22Quote%22,%20%22context%22:%7B%22symbol%22:%22MSFT%22%7D%7D%5D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants