-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vector data cubes (overview) #58
Comments
I'm not a fan of restricting in the standard; maybe, if restricting would be required for easier implementation, we could add this info to the backend capabilities. It would be useful to have metadata about types in a dimension for specific data cubes, though - i.e. if I load a vector cube, it would be good to know which geometry types to expect for the labels on the spatial dimension.
I agree that we leave out PolyhedralSurface etc. (for now). GeometryCollection is borderline - some vector operations might return GC in which case we'll have to "normalize" the results to the higher-dimensional type (e.g. an intersection of two linestrings will most likely be a point, but could also be a linestring; if we support only one type, we'll have to represent all points as degenerate single-point linestrings). Having looked at OGC EDR, it seems that support for XYZ and XYM / XYZM geometries would be useful.
I'd say GeoJSON (the 'non-standard' one with CRS). I don't think ID is necessary - if you strip geometry values from a vector cube, it becomes a non-vector data-cube IMO.
I'd say yes - let's treat geometry labels same as any other labels (e.g. named bands).
Rename
|
Thanks, @mkadunc. Interesting that several of your points are exactly contrary to what @edzer proposed to me before. I guess you can have some good discussions here while I'm on vacation. ;-)
That's a pretty good idea indeed. I should add that to stac-extensions/datacube#10
Right now we say in processes that
Not sure what backends actually do with this in implementation though.
Then it's not GeoJSON though. So you mean the real invalid one (I'd like to avoid that) or were you referring to this new JSON-FG from OGC? https://github.com/opengeospatial/ogc-feat-geo-json (I could see us using that, but it's WIP).
That's breaking and requires processes v2.0. I assume implementors will not be happy about it. (Also, in the schemas we don't really have subclasses except from subclassing native types). |
I also like I think I'm also in favour of a GeoJSON that does not restrict to |
Discussed with @edzer:
|
Question 7: What do we do with additional "metadata", e.g. ids and properties assigned to a feature? Related: Open-EO/openeo-processes#347 (comment) Not sure about the IDs, but I guess for vector data you specify which properties to load into the data cube (as additional dimension if 2+ properties) and the rest is kept somewhere in the background. So we may want to add id and properties as additional optional fields to the vector dimension. There's no way to access these information through processes right now, but we should probably state that id and properties are kept untouched in general by processes unless otherwise stated by processes. This is issue about the additional metadata that is present at the start and may get passed through and should be included in the result is also very much unspecified for raster, by the way. |
I'm not sure I understand this 'additional dimension' part — say we have a vector cube which stores a real-valued variable
|
I agree with @mkadunc and had the same conceptual struggle in Open-EO/openeo-processes#356 |
I think we need to discuss this again in detail with all experts. As we are close to the end of SRR3, we will likely not be able to tackle it beforehand so I'd propose to have a dedicated meeting afterward (or discuss it in Bolzano). |
Some notes from the April PSC meeting:
|
What we need to do to add vector data cubes in openEO:
Questions:
The text was updated successfully, but these errors were encountered: