Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][MIG] sale_pricelist_from_commitment_date: Migration to 16.0 #2656

Merged
merged 11 commits into from
Nov 16, 2023
Merged

[16.0][MIG] sale_pricelist_from_commitment_date: Migration to 16.0 #2656

merged 11 commits into from
Nov 16, 2023

Conversation

santostelmo
Copy link
Contributor

Migration of sale_pricelist_from_commitment_date to 16.0

@santostelmo santostelmo marked this pull request as draft August 28, 2023 12:12
@santostelmo santostelmo force-pushed the 16.0-mig-sale_pricelist_from_commitment_date branch from 00202f3 to 37b7222 Compare August 29, 2023 08:30
@santostelmo santostelmo marked this pull request as ready for review August 29, 2023 08:36
@santostelmo santostelmo mentioned this pull request Aug 29, 2023
Open
100 tasks
@santostelmo santostelmo force-pushed the 16.0-mig-sale_pricelist_from_commitment_date branch from 37b7222 to 57041ad Compare August 29, 2023 09:40
@rousseldenis
Copy link
Contributor

/ocabot migration sale_pricelist_from_commitment_date

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Aug 29, 2023
rousseldenis
rousseldenis approved these changes Aug 29, 2023
View reviewed changes
Copy link
Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

simahawk
simahawk approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@simahawk simahawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@santostelmo can you fix the version?

sale_pricelist_from_commitment_date/__manifest__.py Outdated Show resolved Hide resolved
@santostelmo santostelmo force-pushed the 16.0-mig-sale_pricelist_from_commitment_date branch from 57041ad to 96b31e4 Compare November 16, 2023 10:18
@santostelmo
Copy link
Contributor Author

@santostelmo can you fix the version?

Version fixed

@simahawk
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-2656-by-simahawk-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Nov 16, 2023
@OCA-git-bot
Merge PR #2656 into 16.0
b499df9 
Signed-off-by simahawk
@OCA-git-bot
Copy link
Contributor

It looks like something changed on 16.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 16.0-ocabot-merge-pr-2656-by-simahawk-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 01508c4 into OCA:16.0 Nov 16, 2023
6 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at c72926d. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rousseldenis rousseldenis rousseldenis approved these changes

@cyrilmanuel cyrilmanuel cyrilmanuel approved these changes

@simahawk simahawk simahawk approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 migration needs review ready to merge
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
8 participants
@santostelmo @rousseldenis @OCA-git-bot @simahawk @cyrilmanuel @jcoux @oca-travis @SilvioC2C