Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sphinx: remove whitespace from phase #178378

Merged
merged 1 commit into from
Jun 21, 2022
Merged

sphinx: remove whitespace from phase #178378

merged 1 commit into from
Jun 21, 2022

Conversation

kamadorueda
Copy link
Member

@kamadorueda kamadorueda commented Jun 20, 2022 •
edited
Loading

  • This whitespace causes a derivation diff after
    formatting the file and therefore affects
    reproducibility
  • Since sphinx is a very popular package, a lot of packages reproducibility is also affected
Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@kamadorueda kamadorueda changed the base branch from master to staging June 20, 2022 22:58
@github-actions github-actions bot added the 8.has: documentation This PR adds or changes documentation label Jun 20, 2022
@kamadorueda
sphinx: remove whitespace from phase
90a8d68 
- This whitespace causes a derivation diff after
  formatting the file and therefore affects
  reproducibility
@github-actions github-actions bot removed the 8.has: documentation This PR adds or changes documentation label Jun 20, 2022
@veprbl
Copy link
Member

veprbl commented Jun 21, 2022 •
edited by SuperSandro2000
Loading

@GrahamcOfBorg eval

@ofborg ofborg bot requested a review from SuperSandro2000 June 21, 2022 00:30
@SuperSandro2000 SuperSandro2000 removed the request for review from IvarWithoutBones June 21, 2022 15:48
@SuperSandro2000
Copy link
Member

If ofborg does not eval now, we need to wait until the fix from master is in staging. That should be soonish. Change should be safe none the less.

@SuperSandro2000 SuperSandro2000 merged commit 801bfca into NixOS:staging Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kamadorueda @veprbl @SuperSandro2000