Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnome.nautilus: No thumbnails for heic/heif files #164021

Closed
asbachb opened this issue Mar 13, 2022 · 12 comments
Closed

gnome.nautilus: No thumbnails for heic/heif files #164021

asbachb opened this issue Mar 13, 2022 · 12 comments
Labels
0.kind: bug Something is broken

Comments

@asbachb
Copy link
Contributor

asbachb commented Mar 13, 2022

Describe the bug

Gnome nautilus does not generate thumbnails for heic/heif files.

Steps To Reproduce

Steps to reproduce the behavior:

  1. Ensure thumbnails are enabled in preferences
  2. Open a folder containing heic files

Screenshots

image

Notify maintainers

@hedning
@jtojnar
@dasj19
@maxeaubrey

Metadata

 asbachb@nixos-t14s  ~  nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 5.16.12, NixOS, 22.05 (Quokka)`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.7.0`
 - channels(asbachb): `""`
 - channels(root): `"nixos, nixos-hardware"`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`
@asbachb asbachb added the 0.kind: bug Something is broken label Mar 13, 2022
@jtojnar
Copy link
Member

jtojnar commented Mar 13, 2022

Hi, this is well known issue, see #87033. Currently it is blocked on #153275.

@usul0184
Copy link

Sorry, a bit confused; it looks like #87033 is closed as complete. #153275 is still in draft, though. Is the blocker still #153275?

@jtojnar
Copy link
Member

jtojnar commented Apr 25, 2024

Actually, #153275 was not a blocker for this issue, only for displaying the files in eog.

environment.systemPackages = [ pkgs.libheif pkgs.libheif.out ];
environment.pathsToLink = [ "share/thumbnailers" ];

should be sufficient since #212842 added libheif pixbuf-loader and thumbnailer.

@jtojnar
Copy link
Member

jtojnar commented Apr 25, 2024

I think this can be closed, people can install the package if they want.

@jtojnar jtojnar closed this as completed Apr 25, 2024
@usul0184
Copy link

Is heif.thumbnailer supposed to be automatically installed into /run/current-system/sw/share/thumbnailers? If not, how do you do so? Thanks!

@jtojnar
Copy link
Member

jtojnar commented Apr 26, 2024

See #164021 (comment)

@usul0184
Copy link

Maybe I'm doing something wrong, but I still don't see heif.thumbnailer in /run/current-system/sw/share/thumbnailers even after adding environment.pathsToLink = [ "share/thumbnailers" ];? For what it's worth, I do see evince.thumbnailer, gnome-font-viewer.thumbnailer, and totem.thumbnailer.

@jtojnar
Copy link
Member

jtojnar commented Apr 29, 2024

Apparently, libheif has bin as the default output so you would need environment.systemPackages = [ pkgs.libheif pkgs.libheif.out ];

Edit: the thumbnailer file does not use an absolute path so you need both outputs.

@Saiv46
Copy link

Saiv46 commented May 20, 2024

@jtojnar Shouldn't this be included in package itself? Or maybe as heif-thumbnailer like other distributions did

environment.systemPackages = [ pkgs.libheif pkgs.libheif.out ];
environment.pathsToLink = [ "share/thumbnailers" ];

@jtojnar
Copy link
Member

jtojnar commented May 20, 2024

It would be possible to add it to Nautilus but it is not clear to me how common these file types are and if the increased closure size is worth it. We already had people complaining about our Nautilus package being bloated by GStreamer.

environment.pathsToLink is only necessary if you do not use a desktop environment (e.g. GNOME) or build your own from scratch.

It would be nice to split the thumbnailer into a separate output so that user could just install pkgs.libheif.thumnailer. We have an issue about that: #32817 Patches welcome.

@Saiv46
Copy link

Saiv46 commented May 28, 2024

environment.pathsToLink is only necessary if you do not use a desktop environment (e.g. GNOME)

Well, I use Cinnamon right from NixOS installer, it's strange how it's not working out-of-the-box.

@jtojnar
Copy link
Member

jtojnar commented May 28, 2024

Cinnamon links everything in /share just like GNOME:

"/share" # TODO: https://github.com/NixOS/nixpkgs/issues/47173

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind: bug Something is broken
Projects
None yet
Development

No branches or pull requests

4 participants