Sub-GHz: Nexus-TH weather station protocol improvements on detection #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added detection improvements for Nexus-TH as in https://github.com/merbanan/rtl_433/blob/00bd97c63a58083d2a79ccb7089786ff9d0fda2e/src/devices/nexus.c#L63-L78 : - If hum==0% there's no humidity sensor, so don't overwrite to 20% - If the Rubicson check matches, then it's probably not a Nexus-TH - Check temp range beween -50C and 100C
m7i-org
requested review from
Willy-JL,
Sil333033,
HaxSam and
MatthewKuKanich
as code owners
|
@htotoo your .sub-generator is linked in the source, I imagine you might have something to say about the changes? |
Willy-JL
approved these changes
Oct 11, 2024
Willy-JL
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new
Added detection improvements for Nexus-TH as in https://github.com/merbanan/rtl_433/blob/00bd97c63a58083d2a79ccb7089786ff9d0fda2e/src/devices/nexus.c#L63-L78 :
I haven't found the time of looking into changing the display name (rtl_433 calls the sensor a Nexus-T if there's no humidity), but I think this is good enough.
For the reviewer