Show satellites with an icon #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m7i-org
requested review from
Willy-JL,
Sil333033,
HaxSam and
MatthewKuKanich
as code owners
Replaces the display of the number of satellites during SubGHz scanning. If GPS is enabled (an an external module connected) it will blink a GPS icon with the number of sats currently in range (even if zero). Using a 10x10px "positioning" icon that replaces the SubGHz icon on the bottom right.
m7i-org
force-pushed
the
feature/subghz_show_satellites
branch
from
af499f6 to
065144a
Compare
|
neat idea! maybe the pin could be 1 pixel shorter, ideal would be a bit thinner towards the bottom but its already the thinnest it can be, so maybe 1 pixel shorter. ill see if it looks better |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the display of the number of satellites during SubGHz scanning. If GPS is enabled (an an external module connected) it will blink a GPS icon with the number of sats currently in range (even if zero). Using a 10x10px "positioning" icon that replaces the SubGHz icon on the bottom right.
What's new
Screenshot:
For the reviewer