Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement Request: use the Blizzard AddOns Compartment (PR92 is a suggested update to include) #91

Open
JPEscher opened this issue Aug 6, 2024 · 5 comments

Comments

@JPEscher
Copy link

JPEscher commented Aug 6, 2024

As per: https://warcraft.wiki.gg/wiki/Addon_compartment
a new feature with DF was the addons compartment for easy access to add on configs without cluttering the minimap
would it be possible to use it?

i tried what they show for manual at the link in Interface/AddOns/Mapster/Config.lua
and this code seems to work. hope it helps!


local aboutText = "Mapster";
local mouseButtonNote = "\nYour Map, Improved";
AddonCompartmentFrame:RegisterAddon({
	text = aboutText,
	icon = "Interface/AddOns/Mapster",
	notCheckable = true,
	func = function(button, menuInputData, menu)
		Settings.OpenToCategory("Mapster")
	end,
	funcOnEnter = function(button)
		MenuUtil.ShowTooltip(button, function(tooltip)
			tooltip:SetText(aboutText .. mouseButtonNote)
		end)
	end,
	funcOnLeave = function(button)
		MenuUtil.HideTooltip(button)
	end,
})

image
image

@JPEscher
Copy link
Author

created PR for you to review. hope you like and it helps
#92

@JPEscher JPEscher changed the title Enhancement Request: use the BLizzard AddOns Compartment Enhancement Request: use the Blizzard AddOns Compartment (PR92 is a suggested update to include) Aug 11, 2024
@JPEscher
Copy link
Author

note the ace is out of date... https://github.com/hurricup/WoW-Ace3/tree/master
might wanna grab the zip and update
AceAddon-3.0
AceConfig-3.0
AceConsole-3.0
AceDB-3.0
AceDBOptions-3.0
AceEvent-3.0
AceGUI-3.0
AceHook-3.0
AceLocale-3.0
CallbackHandler-1.0
LibStub

@JPEscher
Copy link
Author

latest official release when i write is https://www.wowace.com/projects/ace3/files/5561981
all are here https://www.wowace.com/projects/ace3/files

@JPEscher
Copy link
Author

based on later findings i came back. i might be wrong on ace. there was an interaction issue due to an out of date mod.

@JPEscher
Copy link
Author

@Nevcairiel have you reviewed this? would love to know if it is accepted, even if the PR is not how you'd like it implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant