-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Interpretation of segmentGroup element constructs #130
Comments
Hi Sam, First off, the One way to make them easier to use and to ensure correct behaviour & test across different cells is to have a helper method in libNeuroML to actually do the calculation of which segments are meant in different scenarios (so that Python applications at least don't have to interpret/reimplement the meaning themselves). There is a method cell.get_all_segments_in_group() which already does this, but does not yet support I've just added a notebook which demonstrates this and other helper methods for cells: https://github.com/NeuralEnsemble/libNeuroML/blob/development/notebooks/CellMorphology.ipynb. Once the issues you mention are clarified I can add more exampels of usage there. Regarding your questions:
Looking at this I think the best solution is to remove the @scrook Any thoughts, does this sound ok? |
Thanks for the explanation! A helper method in libNeuroML would certainly have helped clarify the semantics. |
One difference between the semantics as currently described, is that If the |
Where is it suggested that the On your second point, I can see the use case for defining the concept of "a subset of the morphology" with exact points defined by fractionAlong, but this is a bit different. It's a subelement of segmentGroup, and so explicitly defines a set of segments, no subdivisions. The other concept could potentially be added (I thought for a moment that that was what it referred to when you asked about fractional sections), but it's not there yet. Do you have a specific use case for that? |
Very good point about a fractional segment making it not a segment group: I didn't think this through! I don't have a specific use case, though we are mapping these elements to a description language that can make these sorts of distinctions. While a subregion of interest, in principle, needn't align with the sampling process used to define the morphology, it's certainly not something we need NeuroML to represent. I presumed |
I realize I have been treating When reasoning about what is and isn't included in As an example:
Here, is it correct to say that In |
Good points... Though my first inclination is to use definitions independent of the fraction along, just use the parentage, i.e. follow paths just using the child parent relationship. In your example it would be tricky with seg 2 connected to the proximal of seg 1, but the reconstructor/modeller has still chosen seg1 as the parent, so that's the relation to be used. Taking fractions into account would be a bit strange when you specify from/to in terms of just segment ids and return a set of whole segments. Next step would be to implement the helper method for these and add examples to the notebook to test/clarify these ideas. That would be a week or two for me. I hope this isn't holding you up for NeuroML support implementation... |
Thanks for the response! This does clarify the correct and consistent interpretation. With any luck, I'll have our NeuroML morphology support in Arbor next Monday :) Ultimately it will be helpful for this to be made explicit in the existing documentation, but the helper method will be very useful for verification. |
Thanks. Happy to try out Arbor when the NML support is stable. Please let me know when there's a new release. Yes, docs should be updated too. Thankfully there is a pipeline for generating the documentation from the comments in Lems here, but it just has to be tested and written... |
Hello!
I'm in the process of providing support for reading NeuroML2 morphologies in the Arbor simulator (https://github.com/arbor-sim/arbor), and have some questions concerning the semantics of
path
andsubTree
elements withinsegmentGroup
. I've been using https://neuroml.org/NeuroML2CoreTypes/Cells.html as a reference for the element semantics, and https://github.com/NeuroML/NeuroML2/blob/master/Schemas/NeuroML2/NeuroML_v2.0.xsd for the schema.The schema has
minOccurs="0"
for bothfrom
andto
elements within apath
element. While a missingfrom
element could be interpreted as meaning the path should be taken from the root segment (inclusive), what is the interpretation for a missingto
element?The
subTree
element can be expressed with ato
element instead of afrom
element; is this intended to describe the subset of the morphology which is strictly proximal to the segment identified into
?If I am interpreting the schema correctly, a
subTree
might have neither ato
nor afrom
element. Does this denote the entire morphology? Or perhaps an empty subset?The text was updated successfully, but these errors were encountered: