Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify CommandExecutionHook interface to use HystrixInvokableInfo arguments #857

Closed
mattrjacobs opened this issue Aug 8, 2015 · 1 comment
Closed

Modify CommandExecutionHook interface to use HystrixInvokableInfo arguments #857

mattrjacobs opened this issue Aug 8, 2015 · 1 comment
Labels
enhancement hystrix-core
Milestone
2.0.x

Comments

@mattrjacobs
Copy link
Contributor

Currently, HystrixCommandExecutionHook exposes onXXX(HystrixInvokable<T> commandInstance) methods. Since HystrixInvokable is a marker interface, a cast is always required to write a hook that does anything.

If HystrixInvokableInfo<T> were used, then the common metadata for HystrixCommand/HystrixObservableCommand could be used in hook logic without a cast.
@mattrjacobs mattrjacobs added this to the 2.0.x milestone Aug 8, 2015
@mattrjacobs mattrjacobs mentioned this issue Apr 14, 2016
Merged
@mattrjacobs
Copy link
Contributor Author

Merged into 2.0.x branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement hystrix-core
Projects
None yet
Milestone
2.0.x
Development

No branches or pull requests
1 participant
@mattrjacobs