Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suggestion: appShell should make the SW ignore the generated file sw.js #383

Closed
julienw opened this issue May 23, 2018 · 5 comments
Closed

Comments

@julienw
Copy link
Contributor

julienw commented May 23, 2018

With the current appShell option, when requesting the generated file sw.js, the SW serves the index file. This is quite confusing for the generated sw.js file that actually exists but because it's not in the list of the SW assets, it's being ignored.

@NekR
Copy link
Owner

NekR commented May 23, 2018

Yeah, it's a bit. Though this happens only for navigation requests. But adding this makes sense.

@julienw
Copy link
Contributor Author

julienw commented May 23, 2018

Yep. We got an error where reading the actual sw.js file helped finding the issue. But we could only look at it using eg curl and not load it from the browser.

@NekR
Copy link
Owner

NekR commented May 23, 2018

Makes sense. Thanks for reporting this. 🙌

@NekR NekR closed this as completed in ec987f4 Jun 1, 2018
@NekR
Copy link
Owner

NekR commented Jun 1, 2018

@julienw
Copy link
Contributor Author

julienw commented Jun 1, 2018

Nice, I didn't know that service workers have a location property. TIL :) Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants