Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: gradle error when compileSdk or targetSdk is provided #1825

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

farfromrefug
Copy link
Contributor

Create a meaningful title

Description

Does your commit message include the wording below to reference a specific issue in this repo?

Related Pull Requests

Does your pull request have unit tests?

@edusperoni edusperoni changed the title fix: gradle error whe compileSdk or targetSdk is provided fix: gradle error when compileSdk or targetSdk is provided Oct 15, 2024
@edusperoni
Copy link
Collaborator

When does this error happen? I don't recall every running into it, even when providing compileSdk/targetSdk

@farfromrefug
Copy link
Contributor Author

When those values are passed as number through project properties
Plus it was already done in some cases but not all

@edusperoni edusperoni merged commit a983931 into NativeScript:main Oct 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants