Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLA: determine if commit can be added to the local PR branch #1037

Closed
leondz opened this issue Dec 5, 2024 · 1 comment
Closed

CLA: determine if commit can be added to the local PR branch #1037

leondz opened this issue Dec 5, 2024 · 1 comment
Assignees
Labels
housekeeping Repository and project maintenance
Milestone

Comments

@leondz
Copy link
Collaborator

leondz commented Dec 5, 2024

PRs shouldn't affect main, but because of the CLA setup, signing this doc in a PR ends up changing main without maintainer approval.

Summary

work out if PR signature signing commit can be placed in the PR branch instead of main

Motivation

We should avoid changing main without maintainer approval.

@leondz leondz added the housekeeping Repository and project maintenance label Dec 5, 2024
@leondz leondz added this to the 24.12 milestone Dec 5, 2024
@jmartin-tech
Copy link
Collaborator

After some testing it has been determined that the PR commit cannot be targeted at the PR branch due to permission of the action tokens related to forks, this limits the viable patterns and suggest that the current signatures branch target will be the approach for the time being.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Repository and project maintenance
Projects
None yet
Development

No branches or pull requests

2 participants