New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XCA.ask gives poor mask, and reverse ordering #11

Open

maffettone opened this issue Jun 24, 2021 · 1 comment

Contributor

maffettone commented Jun 24, 2021

XCA should be returning values along a consistent y in clusters of interest.
It also is doing argsort in the wrong order.

ae-gpcam/companion/xca.py

Line 85 in e0196e1

    
           jdxs = np.argsort(self.dependent[:, phase])[np.abs(self.independent[:, 1] - current_y) < 4.5/2]

Contributor Author

maffettone commented Jun 24, 2021

Fixed in eefba97.

main, prby-figure and reconstruction branches left for posterity with December experiment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment