Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify Psyche and Nisar SASF and SATF support #1496

Open
shaheerk94 opened this issue Oct 9, 2024 · 2 comments · May be fixed by #1574
Open

Unify Psyche and Nisar SASF and SATF support #1496

shaheerk94 opened this issue Oct 9, 2024 · 2 comments · May be fixed by #1574
Assignees
Labels
sequencing Anything related to the sequencing domain

Comments

@shaheerk94
Copy link

Checked for duplicates

No - I haven't checked

Alternatives considered

No - I haven't considered

Related problems

Both Psyche and NISAR require SASF and SATF usage but are implemented independently.

Describe the feature request

We should extract SASF and SATF support such that we have one implementation that both adaptations can draw from. New SASF and SATF support can then be added to one place. Need to figure out what the best place for support for these files should be - should they be pulled into core?

@shaheerk94 shaheerk94 added the sequencing Anything related to the sequencing domain label Oct 9, 2024
@shaheerk94 shaheerk94 added this to Aerie Oct 9, 2024
@github-project-automation github-project-automation bot moved this to Todo in Aerie Oct 9, 2024
@dandelany dandelany moved this from Todo to In Review in Aerie Oct 10, 2024
@dandelany dandelany moved this from In Review to Todo in Aerie Oct 10, 2024
@goetzrrGit
Copy link
Contributor

Image

@goetzrrGit
Copy link
Contributor

A primary challenge in this task is the subtle variations in the SATF and SASF formats, specifically headers and sequence invocation, between NISAR and Psyche. While the command steps themselves are identical, the core structures differ.

Currently, the architecture defaults to a SeqJSON core output. Users can either extend this core for their mission, as we did for Clipper or bypass it entirely to generate custom outputs like SATF/SASF, as we did for Psyche and NISAR.

To address this, I propose integrating an AERIE SATF/SASF core similar to the existing SeqJSON core. This core can be customized for specific missions using adaptation files. This approach allows for extending the core output, rather than completely bypassing SeqJSON and building a custom solution with largely redundant code.

If a mission doesn't ouptut SeqJSON, SATF/SASF, the adaptation file can still completely bypass any of these core output. Alternatively, we could consider adding new the new outputs as separate cores, providing greater flexibility.

AERIE currently lacks the flexibility to choose the default core output.

To enhance this functionality, I suggest introducing options like default-seqJSON, default-satf, and default-sasf during parcel creation. This would configure the editor to use the desired core as output and enable missions to customize it via the adaptation for their specific needs, similar to how Clipper tweaked SeqJSON.

@dandelany dandelany moved this from Todo to In Progress in Aerie Dec 5, 2024
@goetzrrGit goetzrrGit linked a pull request Dec 10, 2024 that will close this issue
@dandelany dandelany moved this from In Progress to In Review in Aerie Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sequencing Anything related to the sequencing domain
Projects
Status: In Review
Development

Successfully merging a pull request may close this issue.

2 participants