Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indicate reversion to default parameter after user override #1573

Open
ewferg opened this issue Dec 6, 2024 · 0 comments
Open

Indicate reversion to default parameter after user override #1573

ewferg opened this issue Dec 6, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@ewferg
Copy link

ewferg commented Dec 6, 2024

Checked for duplicates

Yes - I've already checked

Is this a regression?

No - This is a new bug

Version

3.1.1

Describe the bug

When a user places an activity directive onto the timeline, the directive will be populated with default values for parameters if they exist. If a user modifies these parameter values, there is a small color indicator that changes from green to yellow to indicate that the value is now different than the default. If a user then changes that parameter value back to the default, the color indicator remains yellow.

Note that there is a feature that allows you to "reset" the modified value back to its default, which will change the color indicator back to green even if the user had already changed the parameter back to its default value manually. Perhaps this was intended behavior, but I would argue it is not intuitive behavior. The color indicator to me should indicate whether the value has been modified from its default, not just that it has been modified at least once.

Reproduction

Pick any model that has a activity with default parameters, modify the parameter, modify it again back to the default, and you should see the color indicator remain yellow.

Logs

No response

System Info

aerie-test

Severity

Minor

@ewferg ewferg added the bug Something isn't working label Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant