Skip to content
This repository has been archived by the owner on Mar 13, 2023. It is now read-only.

[FEAT] Add Role.clone() method #746

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

AlbertUnruh
Copy link
Contributor

@AlbertUnruh AlbertUnruh commented Jan 8, 2023

What type of pull request is this?

  • Non-breaking code change
  • Breaking code change
  • Documentation change/addition
  • Tests change
  • CI change
  • Other: [Replace with a description]

Description

Two ways to close #731

Changes

  • add two implementations for Role.clone()
    • needs another commit to select the wanted implementation (DocStrings will be added then)
  • add class ClonedRole for one implementation

Test Scenario(s)

Checklist

  • I've formatted my code with Black
  • I've added docstrings to everything I've touched
  • I've ensured my code works on Python 3.10.x
  • I've ensured my code works on Python 3.11.x
  • I've tested my changes
  • I've added tests for my code - if applicable
  • I've updated the documentation - if applicable

@AlbertUnruh AlbertUnruh marked this pull request as ready for review January 9, 2023 16:02
naff/models/discord/role.py Outdated Show resolved Hide resolved
naff/models/discord/role.py Outdated Show resolved Hide resolved
naff/models/discord/role.py Show resolved Hide resolved
@AlbertUnruh
Copy link
Contributor Author

will merge the two methods and add a parameter force which defaults to True

Reference: NAFF #contributors

won't have time for it until Sunday (at least)

@AlbertUnruh
Copy link
Contributor Author

finally had time to make the commit

should all work by now

@leestarb leestarb added the New Feature::Library A new feature for the library label Apr 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
New Feature::Library A new feature for the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants