Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICOc: Improve Channel Names #30

Open
sanssecours opened this issue May 16, 2022 · 1 comment
Open

ICOc: Improve Channel Names #30

sanssecours opened this issue May 16, 2022 · 1 comment
Labels
enhancement New feature or request usability Something does not work as assumed user interface

Comments

@sanssecours
Copy link
Member

Description

For some of the sensor hardware the current channel naming scheme of X, Y and Z does not make sense, since the measured values do not donate acceleration values for a certain axis. We should change the naming scheme to incorporate the type of measured value. For now Christoph (@iftrams) suggested that we should change the name in the user interface to either

  • “Channel 1”, “Channel 2” and “Channel 3” or
  • “Ch1”, ”Ch2” and “Ch3”.

In the future we should also update the names of the measured values (x, y, z) in the HDF5 file that stores the data.

One problem I see with the current suggestion is that it might confuse new users, if the naming in the data file and the user interface is different. Another problem might be that we use the same name for the (up to 8) available channels on the board and the three channels we configured for the current measurement. A sentence like “We configured (measurement) channel 1 to uses channel (number) 2” might be confusing.

@sanssecours sanssecours added enhancement New feature or request usability Something does not work as assumed user interface labels May 16, 2022
@thirschbuechler
Copy link

my suggestion is to use a source and sink notation with additional long-names, e.g

  • sink1 = source0 # ACC0_x
  • print(source0.name)
  • >>> ACC0_x
  • sink2 = source3 # temp0_t
  • sink3 = source4 # DMS0_0_amp

where source denotes the sensor and sink the myt-protocol data-field

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request usability Something does not work as assumed user interface
Projects
None yet
Development

No branches or pull requests

2 participants