Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't crash in the reporting code when some pages don't make use of a font that's used on others #121

Merged
merged 1 commit into from
Jul 26, 2020
Merged

Don't crash in the reporting code when some pages don't make use of a font that's used on others #121

merged 1 commit into from
Jul 26, 2020

Conversation

papandreou
Copy link
Collaborator

@papandreou papandreou self-assigned this Jul 26, 2020
@papandreou papandreou requested a review from Munter July 26, 2020 20:32
@coveralls
Copy link

coveralls commented Jul 26, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 520

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.01%) to 90.177%
Totals Coverage Status
Change from base Build 516: -0.01%
Covered Lines: 1133
Relevant Lines: 1207
💛 - Coveralls

Munter
Munter approved these changes Jul 26, 2020
View reviewed changes
Copy link
Owner

@Munter Munter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@papandreou papandreou merged commit 922ac45 into master Jul 26, 2020
@papandreou papandreou deleted the fix/crashOnEmptyString branch July 26, 2020 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Munter Munter Munter approved these changes

Assignees

@papandreou papandreou

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@papandreou @coveralls @Munter