Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix advancement not triggering for entering nether/end worlds. #218

Merged
merged 1 commit into from
Feb 10, 2021
Merged

Fix advancement not triggering for entering nether/end worlds. #218

merged 1 commit into from
Feb 10, 2021

Conversation

benwoo1110
Copy link
Member

Fixes #184. Basically just trigger it manually instead.

@benwoo1110 benwoo1110 mentioned this pull request Feb 9, 2021
Open
@benwoo1110 benwoo1110 requested a review from nicegamer7 February 9, 2021 10:43
@benwoo1110 benwoo1110 added the PR: Bugfix Pull requests to fix bugs found in MV. label Feb 9, 2021
nicegamer7
nicegamer7 approved these changes Feb 9, 2021
View reviewed changes
Copy link
Member

@nicegamer7 nicegamer7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍. I assume you tested it?

@benwoo1110
Copy link
Member Author

Yep I tested it.

@nicegamer7 nicegamer7 merged commit b45aa6f into main Feb 10, 2021
@nicegamer7 nicegamer7 deleted the fix-advancement branch February 10, 2021 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicegamer7 nicegamer7 nicegamer7 approved these changes

Assignees
No one assigned
Labels
PR: Bugfix Pull requests to fix bugs found in MV.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nether and end portals related advancement not triggered
2 participants
@benwoo1110 @nicegamer7