Skip to content

Commit

Permalink
NOISSUE no means no.
Browse files Browse the repository at this point in the history
  • Loading branch information
@peterix
peterix committed Mar 26, 2020
1 parent 6949053 commit ebb17cb
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions api/logic/minecraft/MojangVersionFormat.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,10 @@ void MojangVersionFormat::readVersionProperties(const QJsonObject &in, VersionFi
{
Bits::readString(in, "id", out->minecraftVersion);
Bits::readString(in, "mainClass", out->mainClass);
if(out->mainClass.contains("forgewrapper") || out->mainClass.contains("zekerzhayard")) {
out->mainClass.clear();
out->addProblem(ProblemSeverity::Error, QObject::tr("Forge workarounds have no place in MultiMC."));
}
Bits::readString(in, "minecraftArguments", out->minecraftArguments);
if(out->minecraftArguments.isEmpty())
{
Expand Down

11 comments on commit ebb17cb

@KrUtOy228omg
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no

@dynamyc010
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no does, in fact, mean no.

@svin24
Copy link

@svin24 svin24 commented on ebb17cb Mar 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no
( •_•)>⌐■-■
(⌐■_■)

@ZekerZhayard
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why?

@timas130
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

y e s

@IRISHMAN04
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if You Wanted to go to Heaven but God said Forge workarounds have no place in MultiMC.

@123chess456
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great commit. People shouldn't be allowed to use MultiMC in ways we do not envision. Please keep preventing people from doing unauthorized modifications. Modifications have no place in MultiMC.

@LemmaEOF
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now this is just unreasonably petty tbh

@Kinomora
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wish I could downvote commits

@kosma
Copy link

@kosma kosma commented on ebb17cb Mar 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity, what's the reason for this commit? People using forgewrapper and then complaining to MultiMC authors when things break?

@peterix
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scorched earth policy when it comes to forge > 1.12

Please sign in to comment.