Skip to content

Commit

Permalink
GH-2544 enable Forge install button for >= 1.13
Browse files Browse the repository at this point in the history
  • Loading branch information
@peterix
peterix committed Mar 28, 2020
1 parent 0281845 commit c9e851f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion application/pages/instance/VersionPage.cpp
View file
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@ void VersionPage::updateVersionControls()
bool newCraft = controlsEnabled && (minecraftVersion >= Version("1.14"));
bool oldCraft = controlsEnabled && (minecraftVersion <= Version("1.12.2"));
ui->actionInstall_Fabric->setEnabled(newCraft);
ui->actionInstall_Forge->setEnabled(oldCraft);
ui->actionInstall_Forge->setEnabled(true);
ui->actionInstall_LiteLoader->setEnabled(oldCraft);
ui->actionReload->setEnabled(true);
updateButtons();
Expand Down

12 comments on commit c9e851f

@sorayori
Copy link

@sorayori sorayori commented on c9e851f Mar 28, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woah when did they fix forge's issue with >1.12?

@DaemonUmbra
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was never broken?
The installation system was changed in a way that meant MultiMC couldn't just extract the Forge jar and go.

@sorayori
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was never broken?
The installation system was changed in a way that meant MultiMC couldn't just extract the Forge jar and go.

ah sorry, that's what i meant. when did the fix forge's issue. i've been using forge 1.15 for a while, i know it works.

@mhanuszh
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@peterix May I ask why? I mean... what changed since your talk with cpw?

@peterix
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot stop the flood with a sieve. When the water starts rising, it's time for a boat.

@ShayBox
Copy link

@ShayBox ShayBox commented on c9e851f Apr 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That doesn't answer what changed, I don't see any commits that change any code to add support for the new forge system, so are you just building and packaging forge externally for 1.13+ now?

@phit
Copy link
Contributor

@phit phit commented on c9e851f Apr 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ShayBox MultiMC/meta@fb05f44

@WaldoTheRanger
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very happy to see this.
Just out of curiosity, are there any drawbacks to this that we should be aware of, things like ease of transferring installs or whatnot that you were talking about before?

@wgaylord
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am confused. Did you write a hack to run the install on your server to get the required jars or something.

@kb-1000
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wgaylord MultiMC/meta@fb05f44

@wgaylord
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea. That’s what I am talking about? What sort of crazy hack is he doing in that.

@kb-1000
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just adding ForgeWrapper to the required libraries

Please sign in to comment.